Skip to content

fix(pegboard-gateway): fix server -> client websocket close not working #2981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix(pegboard-gateway): fix server -> client websocket close not working #2981

wants to merge 1 commit into from

Conversation

@NathanFlurry
Copy link
Member

No description provided.

@NathanFlurry NathanFlurry mentioned this pull request Sep 25, 2025
Closed
@vercel
Copy link

vercel bot commented Sep 25, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
rivet-cloud Error Error Sep 25, 2025 11:24pm
rivet-site Ready Ready Preview Comment Sep 25, 2025 11:24pm
rivet-studio Ready Ready Preview Comment Sep 25, 2025 11:24pm

@MasterPtato MasterPtato mentioned this pull request Sep 25, 2025
Closed
@NathanFlurry Graphite App
Copy link
Member Author

NathanFlurry commented Sep 25, 2025 •
edited by MasterPtato
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@claude
Copy link

claude bot commented Sep 25, 2025 •
edited
Loading

Claude encountered an error —— View job

I'll analyze this and get back to you.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Sep 25, 2025 •
edited
Loading

Open in StackBlitz

npm i https://pkg.pr.new/rivet-dev/engine/@rivetkit/engine-runner@2981

npm i https://pkg.pr.new/rivet-dev/engine/@rivetkit/engine-runner-protocol@2981

commit: ae7593e

MasterPtato
MasterPtato approved these changes Sep 25, 2025
View reviewed changes
packages/core/guard/core/src/proxy_service.rs
)
.await
{
match dbg!(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to get rid of this debug sometime

@NathanFlurry NathanFlurry force-pushed the 09-24-fix_pegboard-gateway_fix_server_-_client_websocket_close_not_working branch from 49b6a6a to e95a4e1 Compare September 25, 2025 01:13
@NathanFlurry NathanFlurry force-pushed the 09-24-chore_docker_add_default_token_to_dev_docker branch from 54b0934 to 884c9a1 Compare September 25, 2025 01:13
@claude
Copy link

claude bot commented Sep 25, 2025 •
edited
Loading

Claude encountered an error —— View job

I'll analyze this and get back to you.

@MasterPtato MasterPtato mentioned this pull request Sep 25, 2025
Closed
@NathanFlurry NathanFlurry mentioned this pull request Sep 25, 2025
Closed
@claude
Copy link

claude bot commented Sep 25, 2025 •
edited
Loading

Claude encountered an error —— View job

I'll analyze this and get back to you.

@NathanFlurry NathanFlurry force-pushed the 09-24-chore_docker_add_default_token_to_dev_docker branch from 884c9a1 to 440a406 Compare September 25, 2025 06:07
@NathanFlurry NathanFlurry force-pushed the 09-24-fix_pegboard-gateway_fix_server_-_client_websocket_close_not_working branch from e95a4e1 to 93cd7f6 Compare September 25, 2025 06:07
@NathanFlurry NathanFlurry mentioned this pull request Sep 25, 2025
Closed
@claude
Copy link

claude bot commented Sep 25, 2025 •
edited
Loading

Claude encountered an error —— View job

I'll analyze this and get back to you.

@claude
Copy link

claude bot commented Sep 25, 2025 •
edited
Loading

Claude encountered an error —— View job

I'll analyze this and get back to you.

This was referenced Sep 25, 2025
Closed
Closed
Closed
This was referenced Sep 25, 2025
Closed
Closed
@NathanFlurry NathanFlurry force-pushed the 09-24-fix_pegboard-gateway_fix_server_-_client_websocket_close_not_working branch from 93cd7f6 to 81e5e63 Compare September 25, 2025 09:19
@NathanFlurry NathanFlurry force-pushed the 09-24-chore_docker_add_default_token_to_dev_docker branch from 440a406 to 2883806 Compare September 25, 2025 09:19
@claude
Copy link

claude bot commented Sep 25, 2025 •
edited
Loading

Claude encountered an error —— View job

I'll analyze this and get back to you.

@NathanFlurry NathanFlurry mentioned this pull request Sep 25, 2025
Closed
@claude
Copy link

claude bot commented Sep 25, 2025 •
edited
Loading

Claude encountered an error —— View job

I'll analyze this and get back to you.

@NathanFlurry NathanFlurry mentioned this pull request Sep 25, 2025
Closed
@MasterPtato MasterPtato force-pushed the 09-24-chore_docker_add_default_token_to_dev_docker branch from 2883806 to de88310 Compare September 25, 2025 19:29
@MasterPtato MasterPtato force-pushed the 09-24-fix_pegboard-gateway_fix_server_-_client_websocket_close_not_working branch from 81e5e63 to 0c4837e Compare September 25, 2025 19:29
@claude
Copy link

claude bot commented Sep 25, 2025 •
edited
Loading

Claude encountered an error —— View job

I'll analyze this and get back to you.

@MasterPtato MasterPtato mentioned this pull request Sep 25, 2025
Closed
@NathanFlurry NathanFlurry force-pushed the 09-24-fix_pegboard-gateway_fix_server_-_client_websocket_close_not_working branch from 0c4837e to ae7593e Compare September 25, 2025 23:12
@NathanFlurry NathanFlurry force-pushed the 09-24-chore_docker_add_default_token_to_dev_docker branch from de88310 to 053e9d9 Compare September 25, 2025 23:12
@graphite-app
Copy link
Contributor

graphite-app bot commented Sep 25, 2025 •
edited
Loading

Merge activity

  • Sep 25, 11:13 PM UTC: MasterPtato added this pull request to the Graphite merge queue.
  • Sep 25, 11:14 PM UTC: CI is running for this pull request on a draft pull request (#2997) due to your merge queue CI optimization settings.
  • Sep 25, 11:15 PM UTC: Merged by the Graphite merge queue via draft PR: #2997.

@claude
Copy link

claude bot commented Sep 25, 2025 •
edited
Loading

Claude encountered an error —— View job

I'll analyze this and get back to you.

@claude
Copy link

claude bot commented Sep 25, 2025 •
edited
Loading

Claude encountered an error —— View job

I'll analyze this and get back to you.

graphite-app bot pushed a commit that referenced this pull request Sep 25, 2025
@NathanFlurry
fix(pegboard-gateway): fix server -> client websocket close not worki…
bd9721b 
…ng (#2981)
@graphite-app graphite-app bot closed this Sep 25, 2025
@graphite-app graphite-app bot deleted the 09-24-fix_pegboard-gateway_fix_server_-_client_websocket_close_not_working branch September 25, 2025 23:15
@github-actions github-actions bot mentioned this pull request Sep 25, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MasterPtato MasterPtato MasterPtato approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@NathanFlurry @MasterPtato